Experimenting with Phabricator for reviews

[Phillip Cohen]

> Augie just added a herald rule that adds the hg-reviewers as a
> blocking reviewer to all HG reviews.  So you can accept
> whatever diffs you want, to indicate you > are happy with them,
> but the diff as a whole won't be "Accepted" until someone from
> hg-reviewers accepts it.

That works for me! Thanks.

> Another thing that I'd like: can we drop the "[Differential] [Foo
> blah]"? It seems mostly useless information and wastes precious
> horizontal real estate.

I think the only limitation is that (to my knowledge, based on Jun's
phabsend API choices) we're trying to avoid patching our local
Phabricator instance and keep it in sync with the upstream version
(maintainers of our Phab instance, please correct me if I'm wrong). If
so we'd have to achieve this via existing Phabricator configs or
extensions. Looking upstream (https://secure.phabricator.com/T5244,
https://secure.phabricator.com/D9342), it looks like this is something
they don't want to support. But curiously, in the latter link, the
creator suggested just patching it locally.

On Wed, Jul 12, 2017 at 12:44 PM, Durham Goode <durham at fb.com> wrote:
> On 7/12/17 12:41 PM, Phillip Cohen wrote:
>>>
>>> Also: Jun has suggested to me that we should avoid using "Accept
>>> Commit", because that should be a state applied only when a commit is
>>> queued to `hg-committed` (either by the reviewer or by a future bot).
>>> Once the commit goes to `hg` it should be automatically closed (this
>>> should happen today out of the box).
>>>
>>> Those two things make sense to me, but it's the first I've heard of
>>> it, and wanted to make sure there was consensus.
>>
>>
>> Although, hm, I find this rather annoying because I have to check
>> whether a review is a core review or an fb-hgext review before I know
>> if I can use the Accept functionality. :/
>
>
> Augie just added a herald rule that adds the hg-reviewers as a blocking
> reviewer to all HG reviews.  So you can accept whatever diffs you want, to
> indicate you are happy with them, but the diff as a whole won't be
> "Accepted" until someone from hg-reviewers accepts it.
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel