[Differential] [Accepted] D63: rebase: use one dirstateguard for when using rebase.singletransaction
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Wed Jul 12 16:27:08 EDT 2017
martinvonz accepted this revision.
martinvonz added inline comments.
This revision is now accepted and ready to land.
INLINE COMMENTS
> test-rebase-base.t:400
> + > EOF
> +- We should only see two status stored messages. One from the start, one from
> +- the end.
I haven't seen this style of starting a comment with '-' elsewhere, so it feels more confusing than helpful. I can see the point of doing it to indicate intra-testcase comments (as opposed to the per-testcase comments like on line 382), but only if we try to do it somewhat consistently. Should I drop it in flight or do you want us to start using this style?
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D63
EMAIL PREFERENCES
https://phab.mercurial-scm.org/settings/panel/emailpreferences/
To: durham, #hg, martinvonz
Cc: mercurial-devel
More information about the Mercurial-devel
mailing list