Experimenting with Phabricator for reviews

[Phillip Cohen]

I'm using the webui, though, so it all looks the same.

On Wed, Jul 12, 2017 at 1:35 PM, Sean Farley <sean at farley.io> wrote:
>
> Phillip Cohen <phillip at phillip.io> writes:
>
>>> Also: Jun has suggested to me that we should avoid using "Accept
>>> Commit", because that should be a state applied only when a commit is
>>> queued to `hg-committed` (either by the reviewer or by a future bot).
>>> Once the commit goes to `hg` it should be automatically closed (this
>>> should happen today out of the box).
>>>
>>> Those two things make sense to me, but it's the first I've heard of
>>> it, and wanted to make sure there was consensus.
>>
>> Although, hm, I find this rather annoying because I have to check
>> whether a review is a core review or an fb-hgext review before I know
>> if I can use the Accept functionality. :/
>
> Historically, this is done via different mailing lists: hgsubversion,
> hg-git, etc. are all separate lists. I would think fb-hgext and whatnot
> could be separate lists, too, no?
>
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
>