[Differential] [Commented On] D66: histedit: extract InterventionRequired transaction handling to utils

lothiraldan (Boris Feld) phabricator at mercurial-scm.org
Thu Jul 13 04:42:18 EDT 2017


lothiraldan added a comment.


  LGTM apart from the condition change

INLINE COMMENTS

> util.py:599
> +    """
> +    if not tr:
> +        yield

The initial check was slighty more precise (if tr is not None), any specific reason for the change?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D66

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers
Cc: lothiraldan, mercurial-devel


More information about the Mercurial-devel mailing list