[Differential] [Accepted] D65: histedit: create transaction outside of try

[durham (Durham Goode)]

durham accepted this revision.
durham added inline comments.

INLINE COMMENTS

> histedit.py:1120
> +        # external process it may choose to commit the transaction first.
> +        tr = repo.transaction('histedit')
>  

It might be more technically correct to do this after state.write() happens.  state.write() is intended to be called before the transaction, and it only technically works right here because it's ignoring the pending transaction (which could be fixed in the future).

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D65

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers, dsp, durham
Cc: durham, mercurial-devel