[Differential] [Commented On] D65: histedit: create transaction outside of try

[martinvonz (Martin von Zweigbergk)]

martinvonz added inline comments.

INLINE COMMENTS

> durham wrote in histedit.py:1120
> It might be more technically correct to do this after state.write() happens.  state.write() is intended to be called before the transaction, and it only technically works right here because it's ignoring the pending transaction (which could be fixed in the future).

Good point. I did notice that state.write(). Not sure why I didn't place this after.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D65

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers, dsp, durham
Cc: durham, mercurial-devel