[PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

[Sean Farley]

Pulkit Goyal <7895pulkit at gmail.com> writes:

> # HG changeset patch
> # User Pulkit Goyal <7895pulkit at gmail.com>
> # Date 1499856010 -19800
> #      Wed Jul 12 16:10:10 2017 +0530
> # Node ID e8200f6a0783798ad61cd84f73c1721264966f02
> # Parent  3d742534fa70a38a2b540cfb0bf68610ecc63d0e
> # EXP-Topic fbext
> commitextras: check the format of the arguments and no internal key is used
>
> This patch adds check to make the arguments are passed as KEY=VALUE and no key
> which is used internally is passed.
>
> This patch also adds test for the extension.

I'm fine with this as an extension to add --extra to commit (without
needing debugcommit). Any others have a problem with it?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170713/b6bb460c/attachment.sig>