[PATCH 2 of 2 v2] commitextras: check the format of the arguments and no internal key is used

[Matt Harbison]

On Thu, 13 Jul 2017 16:44:35 -0400, Sean Farley <sean at farley.io> wrote:

>
> Pulkit Goyal <7895pulkit at gmail.com> writes:
>
>> # HG changeset patch
>> # User Pulkit Goyal <7895pulkit at gmail.com>
>> # Date 1499856010 -19800
>> #      Wed Jul 12 16:10:10 2017 +0530
>> # Node ID e8200f6a0783798ad61cd84f73c1721264966f02
>> # Parent  3d742534fa70a38a2b540cfb0bf68610ecc63d0e
>> # EXP-Topic fbext
>> commitextras: check the format of the arguments and no internal key is  
>> used
>>
>> This patch adds check to make the arguments are passed as KEY=VALUE and  
>> no key
>> which is used internally is passed.
>>
>> This patch also adds test for the extension.
>
> I'm fine with this as an extension to add --extra to commit (without
> needing debugcommit). Any others have a problem with it?

The only thing I question is if the named key should be automatically  
prefixed with 'user:' or similar.  It seems like it tries to prevent  
naming internally used keys, but only two at that.  It's not clear to me  
why those two get special protection.