[Differential] [Commented On] D60: match: remove unused negatematcher

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Fri Jul 14 14:16:02 EDT 2017


martinvonz added a comment.


  In https://phab.mercurial-scm.org/D60#1166, @durham wrote:
  
  > As I mentioned in IRC, this is actually important for scalability, since I think 'visitdir' has to return True for any negatematcher, since it can't know what is or isn't relevant to the underlying matcher.
  
  
  It could actually return False if the underlying matcher returns 'all'.
  
  I now realize that that value is poorly documented. What 'all' actually means is not just that all subdirectories should be visited, but also that all files in them match. See use in treemanifest._match(). I should fix the docstring...

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D60

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers, durham
Cc: durham, mercurial-devel


More information about the Mercurial-devel mailing list