[Differential] [Commented On] D21: rebase: rewrite defineparents

quark (Jun Wu) phabricator at mercurial-scm.org
Fri Jul 14 20:25:17 UTC 2017


quark added inline comments.

INLINE COMMENTS

> durin42 wrote in rebase.py:910
> I can't figure out what this comment is trying to tell me. Why on earth would, given the graph I see, rebase rewrite my explicit 'hg rebase -r E -d F' into having B' as the destination?

Good catch. Will add more text here.

> durin42 wrote in rebase.py:928
> Again, I'm confused. What's the rebase operation in play that is linearizing here? I don't even know how I'd spell that on the command line.

This is for multi-dest. I'll move it to a future patch.

> durin42 wrote in rebase.py:964
> Could you expand this docstring to explain what this means? I think that might make the whole change easier to review.

This docstring was unchanged - it is the same as the original function.

> durin42 wrote in rebase.py:1044
> Define ALLSRC - it's not in the codebase prior to this change.

Side effect of splitting. Will avoid using ALLSRC.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D21

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: quark, durin42
Cc: durin42, mercurial-devel


More information about the Mercurial-devel mailing list