Experimenting with Phabricator for reviews

Sean Farley sean at farley.io
Fri Jul 14 19:08:11 EDT 2017


Danek Duvall <danek.duvall at oracle.com> writes:

> Gregory Szorc wrote:
>
>> > On Jul 14, 2017, at 06:30, Yuya Nishihara <yuya at tcha.org> wrote:
>> > 
>> >> On Wed, 12 Jul 2017 11:52:23 -0700, Sean Farley wrote:
>> >> Sean Farley <sean at farley.io> writes:
>> >>> Adrian Buehlmann <adrian at cadifra.com> writes:
>> >>>>> On 2017-07-10 22:00, Kevin Bullock wrote:
>> >>>>> Greetings, Mercurial hackers!
>> >>>>> 
>> >>>>> We've set up an instance of Phabricator that we're going to experiment with for code reviews. At this time, we're not planning on using any of the other features of Phabricator, and the use of Phabricator for reviews is very much *an experiment* - we intend to see how this is going in a little while (probably around the start of the 4.4 cycle). If you're more comfortable submitting and reviewing patches as plain email, that's fine - use of Phabricator is optional. In the meantime, you'll see e-mails coming to the mailing list when activity happens in Phabricator--hopefully we've hit the right settings to make this useful without being too chatty.
>> >>>>> 
>> >>>>> See https://www.mercurial-scm.org/wiki/Phabricator for a little more detail, including how to submit new reviews.
>> >>>> 
>> >>>> Ugh. Looks way too chatty/cluttered for my taste so far (I'm mostly
>> >>>> lurking the list).
>> >>>> 
>> >>>> I'm likely going to unsubscribe Mercurial-devel, if it stays like that...
>> >>> 
>> >>> Yeah, I've found this to be pretty ugly as well; though I don't think
>> >>> it's a function of chatty-ness but rather lack of threading :-(
>> >> 
>> >> Another thing that I'd like: can we drop the "[Differential] [Foo
>> >> blah]"? It seems mostly useless information and wastes precious
>> >> horizontal real estate.
>> > 
>> > Agrees, unfortunately. It's too much for casual contributors. I've set up
>> > filtering rule to blackhole these emails so I can stay sane.
>> 
>> It hasn't helped that the list has been extremely active this week. I took most of a few days off and too was overwhelmed at the volume. Things should hopefully quiet down next week after the freeze.
>> 
>> Although, given the volume of patches these days, I do question if splitting up the mailing list might be fruitful. We could establish a new list for the fire hose of review activity. The dev list could potentially be just for general discussion. Or we could potentially send just the "new review" emails to the dev list. I'm not convinced that we should do this. Just thought I'd throw an idea out there.
>
> Honestly, I'd rather not.  I don't read most of the code review emails, but
> I like seeing them filter through, since it gives me a chance to scan
> through things that might be relevant -- either to Solaris, or our
> extension, or our team, generally.

Yeah, this is my feeling as well. I do find value in skimming messages
and seeing the discussion.

And so far I agree with Augie that my experience has been negative with
phabricator.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170714/92935524/attachment.sig>


More information about the Mercurial-devel mailing list