[PATCH 2 of 2] commandserver: use selector2

Yuya Nishihara yuya at tcha.org
Fri Jul 14 23:37:39 EDT 2017


On Fri, 14 Jul 2017 20:27:27 -0700, Jun Wu wrote:
> # HG changeset patch
> # User Jun Wu <quark at fb.com>
> # Date 1500089181 25200
> #      Fri Jul 14 20:26:21 2017 -0700
> # Node ID a6545c15171810059596259f60574011184c3412
> # Parent  5664763de82b48ca6882bbb624d01d467b4920d0
> # Available At https://bitbucket.org/quark-zju/hg-draft
> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r a6545c151718
> commandserver: use selector2
> 
> Previously, commandserver was using select.select. That could have issue if
> _sock.fileno() >= FD_SETSIZE (usually 1024), which raises:
> 
>   ValueError: filedescriptor out of range in select()

Can we get around it without vendoring selector2, by using poll() for example?


More information about the Mercurial-devel mailing list