[Differential] [Accepted] D94: tests: rewrite test-rebase-detach.t using drawdag

quark (Jun Wu) phabricator at mercurial-scm.org
Sat Jul 15 13:55:36 EDT 2017


quark accepted this revision.
quark added a comment.


  Nice rewrite! I have gone through the history of this file, discussion at https://bz.mercurial-scm.org/1950 and all look good.
  
  I think this can be committed as-is.

INLINE COMMENTS

> test-rebase-detach.t:86
> +
> +Rebasing C onto B using detach (same as not using it):
> +

This test case seems removable. The `--detach` option was added by https://phab.mercurial-scm.org/rHG66d954e76ffb621a4a54aad3705bb28528b71da9, and removed by https://phab.mercurial-scm.org/rHG50f434510da62a3c0222de9cbb3314696dbbdcce.

I guess you are aware of this and just wanted the new code to be functionally equivalent to the old code.

> test-rebase-detach.t:215-222
> +  > H
> +  > | G
> +  > |/|
> +  > F |
> +  > | |
> +  > | E
> +  > |/

Could be slightly simplified to:

  > H
  > | G
  > |/|
  > F E
  > |/
  > A

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D94

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: martinvonz, #hg-reviewers, quark
Cc: quark, mercurial-devel


More information about the Mercurial-devel mailing list