[PATCH 1 of 2 V3] commitextras: move fb extension to core which add extras to a commit

Yuya Nishihara yuya at tcha.org
Mon Jul 17 10:48:13 EDT 2017


On Mon, 17 Jul 2017 10:17:38 -0400, Augie Fackler wrote:
> On Mon, Jul 17, 2017 at 11:10:02PM +0900, Yuya Nishihara wrote:
> > On Sat, 15 Jul 2017 01:31:23 +0530, Pulkit Goyal wrote:
> > > # HG changeset patch
> > > # User Pulkit Goyal <7895pulkit at gmail.com>
> > > # Date 1499799225 -19800
> > > #      Wed Jul 12 00:23:45 2017 +0530
> > > # Node ID e51d188da49636884ae6c0df94f501e84436b857
> > > # Parent  80e1331a7fe970f3e56fde9044949d72d3afdf30
> > > # EXP-Topic fbext
> > > commitextras: move fb extension to core which add extras to a commit
> >
> > I think it's okay to start this as an extension, but I don't think this
> > extension should be advertised. So +1 for queueing this and marking it as
> > EXPERIMENTAL or ADVANCED as follow-up.
> >
> > I'm also fine with adding a hidden config knob to unblock this feature.
> 
> I'm also fine with either approach. It makes me nervous, but we
> already should be robust to corrupt extras entries in the name of
> being futureproof, so let's just proceed instead of being afraid and
> letting that hinder potential nice things.

Queued these, thanks.


More information about the Mercurial-devel mailing list