D110: sparse: add a requirement when a repository uses sparse (BC)

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Mon Jul 17 17:37:28 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> sparse.py:526
>  def _updateconfigandrefreshwdir(repo, includes, excludes, profiles,
> -                                force=False):
> +                                force=False, removing=False):
>      """Update the sparse config and working directory state."""

It feels like this would be clearer as two method: the old one and a new one that just turns sparse off. That would ideally unlink .hg/sparse, no? The new method would not accept includes, excludes, or profiles, and force also doesn't seem relevant as far as I can tell.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D110

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: indygreg, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list