[PATCH resend] run-tests: make sure to check if pygments is installed before using it

Martin von Zweigbergk martinvonz at google.com
Mon Jul 17 19:04:29 EDT 2017


On Mon, Jul 17, 2017 at 3:38 PM, Jun Wu <quark at fb.com> wrote:
> Excerpts from Martin von Zweigbergk's message of 2017-07-17 15:17:40 -0700:
>> On Mon, Jul 17, 2017 at 1:07 PM, Augie Fackler <raf at durin42.com> wrote:
>> > On Mon, Jul 17, 2017 at 12:24:26PM -0700, Jun Wu wrote:
>> >> LGTM.
>> >
>> > Queued, thanks.
>> >
>> >>
>> >> Excerpts from Pulkit Goyal's message of 2017-07-18 00:07:32 +0530:
>> >> > # HG changeset patch
>> >> > # User Pulkit Goyal <7895pulkit at gmail.com>
>> >> > # Date 1500065225 -19800
>> >> > #      Sat Jul 15 02:17:05 2017 +0530
>> >> > # Node ID 37df34ca705cf68eef4fa6b4087eb039f775d4e6
>> >> > # Parent  0353c051d54702a960e4efba1eea6fbc13ad401a
>> >> > run-tests: make sure to check if pygments is installed before using it
>>
>> This means that "run-tests.py --color=always" still gives no color. Do
>> the tests still fail if we take only the tests/test-run-tests.t part
>> of the patch?
>
> Good catch. I think --color=always prints warning or errors out is desirable
> when pygements is not available. So taking only the .t part makes sense to
> me.

I'll accept Pulkit's version so I don't have to mess with it without
his approval. I'll back out the run-tests.py changes in a followup
instead


More information about the Mercurial-devel mailing list