D122: phabricator: add --amend option to phabsend

quark (Jun Wu) phabricator at mercurial-scm.org
Tue Jul 18 12:40:16 EDT 2017


quark added inline comments.

INLINE COMMENTS

> mitrandir wrote in phabricator.py:413
> I think it would be better to use differential.getcommitmessage for this. For example "reviewed by" field is a really nice thing to have in the commit message.

I was trying to make it behave closer to `hg email`. IIRC reviewers have some other plans to show "who accepts" information (that works for both Phabricator and email submits) on hgweb, so I didn't pay too much attention on "Reviewed By" here.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D122

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: quark, #hg-reviewers, mitrandir
Cc: mercurial-devel


More information about the Mercurial-devel mailing list