D97: revset: pass repo when passing ui

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Tue Jul 18 16:30:43 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> yuja wrote in cmdutil.py:2307
> Perhaps these two shouldn't pass `ui` nor `repo`. They evaluate
> internal query.
> 
> Passing `repo` means to take any valid old-style revisions
> ignoring the revset syntax.

Thanks, Yuja. This was fixed in flight by someone.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D97

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: indygreg, #hg-reviewers, durin42
Cc: martinvonz, yuja, durin42, mercurial-devel


More information about the Mercurial-devel mailing list