D135: rebase: use one dirstateguard for when using rebase.singletransaction
martinvonz (Martin von Zweigbergk)
phabricator at mercurial-scm.org
Tue Jul 18 16:42:08 EDT 2017
martinvonz added inline comments.
INLINE COMMENTS
> util.py:612-617
> + def close(self):
> + pass
> + def release(self):
> + pass
> + def abort(self):
> + pass
Are these necessary? Looks like the nullcontextmanager() is now only used where a plain contextmanager is expected. That should also mean that you should be able to replace this class by:
@contextlib.contextmanager
def nullcontextmanager():
yield
REPOSITORY
rHG Mercurial
REVISION DETAIL
https://phab.mercurial-scm.org/D135
EMAIL PREFERENCES
https://phab.mercurial-scm.org/settings/panel/emailpreferences/
To: durham, #hg-reviewers
Cc: martinvonz, mercurial-devel
More information about the Mercurial-devel
mailing list