[POLL] Mass renaming options for consistency + guidelines

Yuya Nishihara yuya at tcha.org
Wed Jul 19 09:11:19 EDT 2017


On Tue, 18 Jul 2017 09:28:02 -0700, Martin von Zweigbergk wrote:
> On Fri, Jul 14, 2017 at 8:34 PM, Yuya Nishihara <yuya at tcha.org> wrote:
> > On Fri, 14 Jul 2017 11:33:29 -0400, Augie Fackler wrote:
> >>
> >> > On Jul 13, 2017, at 11:53, David Demelier <demelier.david at gmail.com> wrote:
> >> >
> >> > Le 13 juil. 2017 5:37 PM, "Augie Fackler" <raf at durin42.com> a écrit :
> >> >
> >> > > On Jul 13, 2017, at 05:15, David Demelier <demelier.david at gmail.com> wrote:
> >> > >
> >> > > Hello,
> >> > >
> >> > > I'm one of the creator of the ConfigConsolidationPlan [0].
> >> > >
> >> > > In Mercurial there was a big issue regarding the options continuously added without any guideline into the hgrc file. This leads to massive inconsistency like :
> >> > >
> >> > >    allowpull
> >> > >    allow_push
> >> > >    assume-tty
> >> > >
> >> > > In the process of renaming those options without breaking existing user installations, we have added a configitems registry + aliases. The aliases offers a way to select the same option with a different section name (e.g. ui.username also search for ui.user).
> >> > >
> >> > > I'll start renaming options once a convention has been chosen correctly, I've proposed (seconded by Pierre-Yves) to use hyphens between words as it's common in projects [2].
> >> >
> >> > When you say "renaming" you just mean renaming the documented name of the option, but still respecting the legacy name, right?
> >> >
> >> >
> >> > Yes, exactly.
> >>
> >> Dashes seem like the only good choice to me, usability-wise.
> >
> > I prefer not doing mass renaming that would generate lots of "deprecated"
> > config names in use around user hgrc and web documents. But if I had to
> > choose one, I would vote for dashes/hyphens.
> 
> We could also do what gmail does with email addresses and periods:
> they allow extra periods anywhere (I think). So allowpull and
> allow-pull and all-owpull would be all be the same config option. Just
> a thought; I'm not sure what I think.

I'm not a fan of ambiguating identifiers. It smells like case-insensitive fs,
computer language, etc. that do sometimes surprising.


More information about the Mercurial-devel mailing list