D153: test-dirstate-race: replace BROKEN line with explanation of changed output

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Jul 20 00:14:06 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> test-dirstate-race.t:223-231
> +The "M b" line in the hg status output used to not exist, but the changes in
> +b63351f6a246 caused the ordering of operations to change such that the dirstate
> +gets written out at a different time. This causes the 'hg status' in the middle
> +to think that "b" is modified. Note that strictly speaking isn't wrong since c4
> +does actually modify "b".
> +
> +Regardless, we're more interested in testing what happens to 'hg status'

The commit that introduced this test case (https://phab.mercurial-scm.org/rHG15e85dded93323d286dc0a758edde1b9dbea5cdd) referred to bug https://bz.mercurial-scm.org/show_bug.cgi?id=5581. The description of that issue (filed by you) finishes with "That last 'hg status' should be empty, but it returns 'M b'.". You changed your mind about what the expected behavior should be?

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D153

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: sid0, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list