D153: test-dirstate-race: replace BROKEN line with explanation of changed output

martinvonz (Martin von Zweigbergk) phabricator at mercurial-scm.org
Thu Jul 20 12:33:23 EDT 2017


martinvonz added inline comments.

INLINE COMMENTS

> sid0 wrote in test-dirstate-race.t:223-231
> I'm afraid not -- debugrebuilddirstate will try to acquire the wlock, which is already held by the rebase.

Makes sense (for others' info: "hg status" will write the dirstate if the lock can be acquired, but will not wait for the lock, IIRC).

How about piping the result of that "hg status" to /dev/null and adding a comment above it saying that we're only calling it to cause the dirstate to be written if the repo is not locked? Then you can get rid of the comment above.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D153

EMAIL PREFERENCES
  https://phab.mercurial-scm.org/settings/panel/emailpreferences/

To: sid0, #hg-reviewers
Cc: martinvonz, mercurial-devel


More information about the Mercurial-devel mailing list