[PATCH 1 of 2 STABLE] setup: do not select hg executable that prints unexpected warnings

[Yuya Nishihara]

On Thu, 20 Jul 2017 22:23:38 -0400, Matt Harbison wrote:
> On Thu, 20 Jul 2017 10:39:52 -0400, Yuya Nishihara <yuya at tcha.org> wrote:
> > # HG changeset patch
> > # User Yuya Nishihara <yuya at tcha.org>
> > # Date 1500557557 -32400
> > #      Thu Jul 20 22:32:37 2017 +0900
> > # Branch stable
> > # Node ID 3f8f39ef616024ac0722c701aeae9105a52728fa
> > # Parent  a41e0f1c9b69330a0dd8d6590787faa38d11c0ff
> > setup: do not select hg executable that prints unexpected warnings
> >
> > Otherwise the subsequent hg.run() would fail. This factors out the  
> > filtering
> > function so the same rule should apply.
> 
> Is it also reasonable to set 'HGRCPATH=' for this?  I know it could break  
> repos with a requires line for an extension, but are those realistically  
> used with a Mercurial repo?

HGRCPATH= should be set for the fallback. Only reason it tries a system hg
is to support non-core storage format.