D152: repo: skip invalidation of changelog if it has 'delayed' changes (API)

[indygreg (Gregory Szorc)]

indygreg accepted this revision as: indygreg.
indygreg added a comment.


  Aside from the test issue pointed out by @quark, I think this seems reasonable.
  
  @martinvonz is correct that writing the .i.a file has hooks implications. We definitely need to keep the changes in memory.
  
  I'm kinda surprised we haven't hit this bug in core. Unless you can find somewhere we can hit it, I'm leaning towards not taking this on stable.
  
  FWIW, these are the kinds of caching bugs that I think a refactor of the repo class into immutable and mutable components can help prevent. The whole property cache mechanism for various things on localrepo is a bug's nest.

REPOSITORY
  rHG Mercurial

REVISION DETAIL
  https://phab.mercurial-scm.org/D152

To: martinvonz, #hg-reviewers, quark, indygreg
Cc: indygreg, quark, mercurial-devel