[Bug 5637] New: in client.py, class hgclient, summary: return value's commit field is wrong when phase is secret

[mercurial-bugs at mercurial-scm.org]

https://bz.mercurial-scm.org/show_bug.cgi?id=5637

            Bug ID: 5637
           Summary: in client.py, class hgclient, summary: return value's
                    commit field is wrong when phase is secret
           Product: Mercurial
           Version: unspecified
          Hardware: PC
                OS: Linux
            Status: UNCONFIRMED
          Severity: feature
          Priority: wish
         Component: hglib
          Assignee: bugzilla at mercurial-scm.org
          Reporter: garrett.mitchener at gmail.com
                CC: mercurial-devel at mercurial-scm.org

One of my scripts ran into this problem with hglib: Some of my repos were in
the secret phase and 'hg summary' shows

commit: (clean) (secret)

In client.py, class hgclient, summary, when building the return value, it only
sets the value of the commit field to True if the commit line is exactly
'(clean)'.  So hglib was telling me that these repos were dirty, which I
believe is incorrect.

I've cloned the source code and tried a more involved check, and what seems to
work best is to check that '(clean)' is in the 'commit:' line, and 'unknown'
isn't, etc. but I don't know what all the possibilities are for that line of
output.

-- 
You are receiving this mail because:
You are on the CC list for the bug.