[PATCH 4 of 5 osx] zsh_completion: install as _hg not hg

Yuya Nishihara yuya at tcha.org
Thu Jun 1 14:19:25 UTC 2017


On Wed, 31 May 2017 14:16:30 -0400, Augie Fackler wrote:
> On Tue, May 30, 2017 at 8:44 PM, Kyle Lippincott <spectral at pewpew.net> wrote:
> > Would it make sense to put this (and the required pkgbuild change) on
> > 'stable' to avoid the issue from the first paragraph of the description?
> >
> > With a name like `hg`, if the user has a line like `autoload
> > ${^fpath}/*(N-.:t)`
> > in their zshrc, it will create a shell function named `hg` that will hide
> > the
> > actual hg command and make hg unusable.
> >
> > I don't know how long this was out there as 'hg' instead of '_hg', so it
> > might be only 4.2 that was affected, and if we have a patch release it would
> > be nice to have less time where packagers might take the potentially
> > very-broken version, instead of waiting for 4.3 to get it out there?
> 
> Sounds good to me. Anyone object? We'd need to graft this patch and
> the OS X installer fix for the .hg ignore in pkgbuild to stable.

+1


More information about the Mercurial-devel mailing list