[PATCH 6 of 8] hidden: remove _consistencyblockers()

[Pierre-Yves David]

On 05/30/2017 07:47 PM, Jun Wu wrote:
> Excerpts from Pierre-Yves David's message of 2017-05-29 19:16:06 +0200:
>> Ho, this is not a set‽ (that is what I've been missing).
>>
>> Hum, we should probably stick to pure python set for the return of
>> phasecase here and only upgrade them to smartset in revset.
>
> smartset is better because:
>
>   - smartset is ordered. If we return a set, some code paths still sort
>     them, which is a waste of time.
>   - smartset could be lazy and therefore more flexible.

(note: I know what smartset do, I kinda wrote them ;-) )

In the case we are discussing (hidden computation, obsolete 
computation). We do not use any of the above property. Martin even had 
to work around some of the limitation with an extra `set` conversion.

a quick check seems to indicate switching to set remove a 20% overhead 
for computing obsolescence and 45% for computing hidden (!). I'll send a 
small series to give these logic access to the set version soonâ„¢.

Cheers,

-- 
Pierre-Yves David