[PATCH 6 of 8] hidden: remove _consistencyblockers()

Jun Wu quark at fb.com
Sat Jun 3 13:38:56 EDT 2017


Excerpts from Martin von Zweigbergk's message of 2017-06-03 10:05:06 -0700:
> [...]
> If all current code paths use the full set (and don't care about order), I

I think we are talking about phase revsets.

The order matters. If you look at 17b5cda5a84a, note that "s.sort()" was
removed to improve performance. 

> think it makes sense to return a plain set. I'd accept a patch that changes
> that. I realize it conflicts with your vision, but it sounds like a pretty
> small patch, so I'm not concerned about the possible churn of taking such a
> patch that you later back out when you make things lazier.


More information about the Mercurial-devel mailing list