[PATCH 6 of 8] hidden: remove _consistencyblockers()

Jun Wu quark at fb.com
Sun Jun 4 01:18:50 EDT 2017


Excerpts from Pierre-Yves David's message of 2017-06-04 03:28:30 +0200:
> I see you point, that is something to consider.
> 
> I'm not fully convinced yet because the following chain  of 
> usage/transformation seems a bit strange at the place where it is used"
> 
>    set → smartset (→ check if smartset has a 'toset' method) → set

I'm not sure why there is a "check if smartset has a 'toset' method" step.

Note the left side won't always be "set" in the future.

> But I'll think about it when we get to the point where is it worthwhile 
> to update that parts of the code and I submit my series to switch to 
> python sets
> 
> Cheers,
> 


More information about the Mercurial-devel mailing list