[PATCH V2] setup: prevent setuptools from laying an egg

Boris Feld boris.feld at octobus.net
Tue Jun 6 09:29:14 EDT 2017


Following this patch, it seems that mercurial default is no longer pip-
installable.

I first saw the issue when playing with https://hg.logilab.org/review/h
gperf where I can see this crash when testing the default branch:

https://bpaste.net/show/e792a21fc6fb

I can also reproduce the crash when trying to pip install mercurial
directly:

https://bpaste.net/show/a11615d5429c

Commenting the following line in setup.py:

'install': hginstall,

is sufficient to make it working.

I'm not exactly sure why we have this crash, maybe the command we
blacklisted was used to detect the version of setuptools and pip think
setuptools is older and supports this version.

Here are my versions:

pip             9.0.1
setuptools      36.0.1 

I have tried to install mercurial both from inside a virtualenv and
outside, I have the same error.

On Sat, 2017-06-03 at 00:50 -0400, Augie Fackler wrote:
> On Sat, Jun 03, 2017 at 12:25:31PM +0900, Yuya Nishihara wrote:
> > On Sun, 28 May 2017 22:32:28 -0400, Matt Harbison wrote:
> > > # HG changeset patch
> > > # User Matt Harbison <matt_harbison at yahoo.com>
> > > # Date 1494214143 14400
> > > #      Sun May 07 23:29:03 2017 -0400
> > > # Node ID b81e017073fbb68a878610377484c5d4d32f683c
> > > # Parent  7422587f7788842413ebb2e6617749ed64895071
> > > setup: prevent setuptools from laying an egg
> > 
> > Looks good per the previous discussion, queued, thanks.
> 
> I also ran this by the pip maintainer and he said it looked like it'd
> probably be okay. Just forgot to follow up here. :)
> 
> > _______________________________________________
> > Mercurial-devel mailing list
> > Mercurial-devel at mercurial-scm.org
> > https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel
> 
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list