[PATCH 04 of 22] obsstore: minor optimization for the obsolete revset

Pierre-Yves David pierre-yves.david at ens-lyon.org
Wed Jun 7 09:50:51 EDT 2017



On 06/06/2017 07:05 AM, Gregory Szorc wrote:
> On Sun, Jun 4, 2017 at 4:59 PM, Jun Wu <quark at fb.com> wrote:
>
>> # HG changeset patch
>> # User Jun Wu <quark at fb.com>
>> # Date 1496457147 25200
>> #      Fri Jun 02 19:32:27 2017 -0700
>> # Node ID e1d6126ed614db6ec664c79afcb3a141c9a0dfa4
>> # Parent  d492628229c58f8417a8b5925a614e26a16465af
>> # Available At https://bitbucket.org/quark-zju/hg-draft
>> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r
>> e1d6126ed614
>> obsstore: minor optimization for the obsolete revset
>>
>
> Queued 4-7.
>
> I wish this one had perf numbers in the commit message. But the patch looks
> correct and avoiding attribute lookups in loops like this is a good
> practice.

I can't find the changeset again, but I had a local version of that with 
timing data. I think it moved the loop from 45ms to 6ms or something 
similarly ridiculous improvement that python can offer.

(and yes +1 for patch 4-7)

Cheers,

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list