[PATCH 2 of 2] localrepo: move filtername to __init__

Pierre-Yves David pierre-yves.david at ens-lyon.org
Fri Jun 9 05:39:07 EDT 2017


On 06/09/2017 07:26 AM, Gregory Szorc wrote:
> # HG changeset patch
> # User Gregory Szorc <gregory.szorc at gmail.com>
> # Date 1496989417 25200
> #      Thu Jun 08 23:23:37 2017 -0700
> # Node ID e1a094a7815f3d906374ff2fe06296cbeaf89fcb
> # Parent  4867bfadaa177b5e43108f2683e64898204827b7
> localrepo: move filtername to __init__
>
> This is obviously an instance attribute, not a type attribute. The
> modern Python style is to use __init__ for defining these.
>
> This exposes statichttprepo as inheriting from localrepository
> without calling its __init__. As a result, its __init__ defines
> a lot of variables that methods on localrepository's methods need.
> But factoring the common bits into a separate class is for another
> day.

+1 for this series.

-- 
Pierre-Yves David


More information about the Mercurial-devel mailing list