[PATCH 3 of 3] Add more tests for formatting and merging of release notes

Sean Farley sean at farley.io
Sun Jun 11 22:34:46 EDT 2017


Sean Farley <sean at farley.io> writes:

> Gregory Szorc <gregory.szorc at gmail.com> writes:
>
>> On Wed, Jun 7, 2017 at 8:24 AM, Kevin Bullock <
>> kbullock+mercurial at ringworld.org> wrote:
>>
>>> On Jun 6, 2017, at 16:41, Gregory Szorc <gregory.szorc at gmail.com> wrote:
>>>
>>> On Tue, Jun 6, 2017 at 12:31 PM, Augie Fackler <raf at durin42.com> wrote:
>>>
>>>> On Tue, Jun 06, 2017 at 11:17:11AM -0500, Kevin Bullock wrote:
>>>> > > On Jun 3, 2017, at 17:28, Rishabh Madan <rishabhmadan96 at gmail.com>
>>>> wrote:
>>>> > >
>>>> > > # HG changeset patch
>>>> > > # User Rishabh Madan <rishabhmadan96 at gmail.com>
>>>> > > # Date 1496528205 -7200
>>>> > > #      Sun Jun 04 00:16:45 2017 +0200
>>>> > > # Node ID 5154239fff11aacb065f4de8081884bfba691eed
>>>> > > # Parent  dfc1e6491b96127ae64504e8dad6cac037b80b6a
>>>> > > Add more tests for formatting and merging of release notes
>>>> >
>>>> > Series looks good with the added tests. I think I'd be ready to land
>>>> > this and start iterating on it, with a goal of having the basic
>>>> > functionality solidified by 4.3 (and thus let us actually use it to
>>>> > generate the 4.3 release notes). What do others think, particularly
>>>> > Greg?
>>>>
>>>> +1 from me. Greg?
>>>>
>>>
>>> There are some lingering bugs and large features that need to be dealt
>>> with. But perfect is the enemy of good. If it is going to be actively
>>> iterated on, we should land it and unblock that work.
>>>
>>>
>>> Are you referring to the bugs that are showing up in the tests, or are
>>> there other known issues?
>>>
>>
>> The "bugs" that I recall are around robustness. IMO there is nothing severe
>> enough to block the initial landing.
>
> Ok then, I've queued this series (some copy-edit on the commit messages,
> though) so that we can make progress. Let's do this!

Also, let's congratulate Rishabh for his first patches!
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170611/f3321f50/attachment.sig>


More information about the Mercurial-devel mailing list