[PATCH 3 of 4] test-dirstate-race: ensure that a isn't in the lookup set at the end

Martin von Zweigbergk martinvonz at google.com
Mon Jun 12 01:21:55 EDT 2017


On Sat, Jun 10, 2017 at 2:10 PM, Siddharth Agarwal <sid0 at fb.com> wrote:
> # HG changeset patch
> # User Siddharth Agarwal <sid0 at fb.com>
> # Date 1497128851 25200
> #      Sat Jun 10 14:07:31 2017 -0700
> # Node ID 212b4b3a41a4edf86cdea2057bfa1c4d3f8a923f
> # Parent  a69ae05fa66239c2aecb3673115de82105c8e9c6
> test-dirstate-race: ensure that a isn't in the lookup set at the end
>
> We're going to rely on this in upcoming patches.
>
> diff --git a/tests/test-dirstate-race.t b/tests/test-dirstate-race.t
> --- a/tests/test-dirstate-race.t
> +++ b/tests/test-dirstate-race.t
> @@ -156,4 +156,4 @@ treated differently in _checklookup() ac
>    $ hg files
>    a
>    $ hg debugdirstate
> -  n * * * a (glob)
> +  n 644          2 unset               a

Doesn't look like it's guaranteed to be unset. Running "run-tests.py
-j50 --runs-per-test=50 test-dirstate-race.t" seems to confirm that (2
of 5 failed for me). How do you rely on it in an upcoming patch?


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list