[PATCH 3 of 4] test-dirstate-race: ensure that a isn't in the lookup set at the end

FUJIWARA Katsunori foozy at lares.dti.ne.jp
Mon Jun 12 06:04:28 EDT 2017


At Sun, 11 Jun 2017 22:24:20 -0700,
Siddharth Agarwal wrote:
> 
> On 6/11/17 10:21 PM, Martin von Zweigbergk via Mercurial-devel wrote:
> > Doesn't look like it's guaranteed to be unset. Running "run-tests.py
> > -j50 --runs-per-test=50 test-dirstate-race.t" seems to confirm that (2
> > of 5 failed for me). How do you rely on it in an upcoming patch?
> 
> 
> Interesting, I'm not seeing that on my Linux box. Could you drop this 
> for now? I think I can work around this problem.

Unfortunately, this can occur, if mtime of "a" is N, and _getfsnow()
returns N+1 or more (= "a" is written out at almost N+1 but N in
"int").

IMHO, "hg update" with --config debug.dirstate.delaywrite=2 should
avoid this problem.


> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel

-- 
----------------------------------------------------------------------
[FUJIWARA Katsunori]                             foozy at lares.dti.ne.jp


More information about the Mercurial-devel mailing list