[PATCH 5 of 5 RFC] patchbomb: add support for a file that configures default To and CC

Yuya Nishihara yuya at tcha.org
Wed Jun 14 10:17:43 EDT 2017

On Tue, 13 Jun 2017 18:50:27 -0400, Augie Fackler wrote:
> Durham had the idea of a tweak to patchbomb that would let us not do https://www.mercurial-scm.org/wiki/Herald.
> I implemented filesets for the RFC, but I think we should probably also allow reset-based subscriptions too (e.g. "histedit" as a keyword or similar). I'd appreciate any feedback people have, since this was a quick project and it feels like it might have some real utility.

Looks pretty nice.

> > @@ -3036,12 +3036,17 @@ Test hg email defaults settings:
> >> [devel.setsubscriptions]
> >> c or d = c-or-d at example.com
> >> a or b = a-or-b at example.com
> > +  > [foo.setsubscriptions]
> > +  > binary() = hates-binary-files at example.com

Perhaps the config syntax could be arbitrary_key:attr = value.

  hatebin:fileset = binary()
  hatebin:revset = keyword(binary)
  hatebin:cc = hates-binary-files at example.com

fileset and revset can be quite long. We wouldn't want to write them as config

And I prefer using matcher patterns instead of fileset for consistency with
the other commands.

More information about the Mercurial-devel mailing list