[PATCH RFC] ui: add support for a tweakdefaults knob

Martin von Zweigbergk martinvonz at google.com
Thu Jun 15 12:34:47 EDT 2017


On Thu, Jun 15, 2017 at 9:32 AM, Augie Fackler <raf at durin42.com> wrote:
>
>> On Jun 15, 2017, at 11:53, Martin von Zweigbergk <martinvonz at google.com> wrote:
>>
>> As I said on IRC, I'd consider testing this in test-config.t and only
>> checking the output of "hg (show)config". Since it will be completely
>> transparent to the users (such as the status command), I think that's
>> probably enough. Or at least it probably means we can test less in the
>> non-config tests. It would also be a natural place for testing setting
>> of the config at different levels (global/user/repo), even if we don't
>> care about perfecting the behavior in that regard (which I agree about
>> leaving for later).
>
> I could see adding that test - but I like having a case that actually demonstrates that this works "in the wild" too. Should I do a v2 with a test-config.t test added?

Yes, I'd appreciate that. I still won't queue it, but only because it
sounded like Yuya wanted to review it in more detail tomorrow. I'm
sure I'll accept it quickly thereafter; I'm looking forward to getting
this in and seeing more of FB's tweakdefaults extension move into
core.


More information about the Mercurial-devel mailing list