Transient Windows test failures

Augie Fackler raf at durin42.com
Fri Jun 16 09:59:30 EDT 2017


On Fri, Jun 16, 2017 at 12:18:18AM -0400, Matt Harbison wrote:
> So apparently, this is a symptom of not having %SystemRoot% in the
> environment when calling CreateProcess().
>
> https://bugs.python.org/issue13524
> https://jpassing.com/2009/12/28/the-hidden-danger-of-forgetting-to-specify-systemroot-in-a-custom-environment-block/
>
> I see that setup.py special cases this variable.  I did a search for 'env
> =', and it looks like hooks and pager start with empty environments, so they
> must not inherit this.  IDR if any recent changes were made that start with
> an empty environment.
>
> The thing I can't get my mind around is the hit and miss nature of the
> error, if this is really the problem.

It sounds like it should be harmless to just always forward
%SystemRoot% - should we just do that?

> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel


More information about the Mercurial-devel mailing list