[PATCH 1 of 3 v2] patchbomb: add test that shows --to and --cc override matching config item

[Martin von Zweigbergk]

On Wed, Jun 14, 2017 at 8:16 PM, Augie Fackler <raf at durin42.com> wrote:
> # HG changeset patch
> # User Augie Fackler <augie at google.com>
> # Date 1497453237 14400
> #      Wed Jun 14 11:13:57 2017 -0400
> # Node ID a2d6d99356a75d5957767d106684652752234931
> # Parent  9d76812f9b0bdd0af9b4ea68bb16765c591d9b4a
> patchbomb: add test that shows --to and --cc override matching config item
>
> As far as I know this has always been true and is intentional (it's in
> line with many other behaviors), but it wasn't tested. Since I'm about
> to tweak To and Cc behavior pretty heavily, let's add a test.
>
> diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t
> --- a/tests/test-patchbomb.t
> +++ b/tests/test-patchbomb.t
> @@ -69,6 +69,45 @@ Mercurial-patchbomb/.* -> Mercurial-patc
>    +a
>
>
> +If --to is specified on the command line, it should override any
> +email.to config setting. Same for --cc:
> +
> +  $ hg email --date '1970-1-1 0:1' -n -f quux --to foo --cc bar -r tip \
> +  >   --config email.to=bob at example.com --config email.cc=alice at example.com

Why not add "| egrep '(^To|Cc):" and to this? I see you're just
following the existing pattern in the file, so it's not your fault,
but do you see a reason to verify all that stuff in the output for
every test? If not, I don't mind sending a followup after your series
has landed.

> +  this patch series consists of 1 patches.
> +
> +
> +  displaying [PATCH] a ...
> +  Content-Type: text/plain; charset="us-ascii"
> +  MIME-Version: 1.0
> +  Content-Transfer-Encoding: 7bit
> +  Subject: [PATCH] a
> +  X-Mercurial-Node: 8580ff50825a50c8f716709acdf8de0deddcd6ab
> +  X-Mercurial-Series-Index: 1
> +  X-Mercurial-Series-Total: 1
> +  Message-Id: <8580ff50825a50c8f716.60 at augie-macbookpro2.roam.corp.google.com>
> +  X-Mercurial-Series-Id: <8580ff50825a50c8f716.60 at augie-macbookpro2.roam.corp.google.com>
> +  User-Agent: Mercurial-patchbomb/4.2.1+627-72f2cafb81e3
> +  Date: Thu, 01 Jan 1970 00:01:00 +0000
> +  From: quux
> +  To: foo
> +  Cc: bar
> +
> +  # HG changeset patch
> +  # User test
> +  # Date 1 0
> +  #      Thu Jan 01 00:00:01 1970 +0000
> +  # Node ID 8580ff50825a50c8f716709acdf8de0deddcd6ab
> +  # Parent  0000000000000000000000000000000000000000
> +  a
> +
> +  diff -r 000000000000 -r 8580ff50825a a
> +  --- /dev/null        Thu Jan 01 00:00:00 1970 +0000
> +  +++ b/a      Thu Jan 01 00:00:01 1970 +0000
> +  @@ -0,0 +1,1 @@
> +  +a
> +
> +
>    $ hg --config ui.interactive=1 email --confirm -n -f quux -t foo -c bar -r tip<<EOF
>    > n
>    > EOF
> _______________________________________________
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
> https://www.mercurial-scm.org/mailman/listinfo/mercurial-devel