[PATCH 1 of 3 v2] patchbomb: add test that shows --to and --cc override matching config item

[Augie Fackler]

> On Jun 16, 2017, at 14:24, Martin von Zweigbergk <martinvonz at google.com> wrote:
> 
> On Wed, Jun 14, 2017 at 8:16 PM, Augie Fackler <raf at durin42.com> wrote:
>> # HG changeset patch
>> # User Augie Fackler <augie at google.com>
>> # Date 1497453237 14400
>> #      Wed Jun 14 11:13:57 2017 -0400
>> # Node ID a2d6d99356a75d5957767d106684652752234931
>> # Parent  9d76812f9b0bdd0af9b4ea68bb16765c591d9b4a
>> patchbomb: add test that shows --to and --cc override matching config item
>> 
>> As far as I know this has always been true and is intentional (it's in
>> line with many other behaviors), but it wasn't tested. Since I'm about
>> to tweak To and Cc behavior pretty heavily, let's add a test.
>> 
>> diff --git a/tests/test-patchbomb.t b/tests/test-patchbomb.t
>> --- a/tests/test-patchbomb.t
>> +++ b/tests/test-patchbomb.t
>> @@ -69,6 +69,45 @@ Mercurial-patchbomb/.* -> Mercurial-patc
>>   +a
>> 
>> 
>> +If --to is specified on the command line, it should override any
>> +email.to config setting. Same for --cc:
>> +
>> +  $ hg email --date '1970-1-1 0:1' -n -f quux --to foo --cc bar -r tip \
>> +  >   --config email.to=bob at example.com --config email.cc=alice at example.com
> 
> Why not add "| egrep '(^To|Cc):" and to this? I see you're just
> following the existing pattern in the file, so it's not your fault,
> but do you see a reason to verify all that stuff in the output for
> every test? If not, I don't mind sending a followup after your series
> has landed.

Sure, that'd be fine. Please feel encouraged to send such a followup (I briefly considered it, but after I had already done all the find and replace dancing...)