[PATCH 3 of 3 v2 pip-fix] tests: add a test for installing hg with pip in a virtualenv
Danek Duvall
danek.duvall at oracle.com
Mon Jun 19 18:38:14 EDT 2017
Danek Duvall wrote:
> Augie Fackler wrote:
>
> >
> > > On Jun 19, 2017, at 18:13, Donald Stufft <donald at stufft.io> wrote:
> > >
> > >>> Any thoughts on what to do here? The ping command has a different
> > >>> interface on Solaris than on Linux, so trying to simply ping
> > >>> pypi.python.org (assuming we can rely on pip always trying that host) is
> > >>> going to run into platform-specific issues. We could save http_proxy
> > >>> aside, and enable it here specifically (somehow). Or we could allow for
> > >>> specific "have"s to be blacklisted, and introduce some sort of
> > >>> external-network #if token, maybe?
> > >>
> > >> I was going to suggest an hghave check that lets us be sure we can see authentic pypi - dstufft, do you have some endpoint that'd be suitable for such a sniff-test?
> > >>
> > >> (The test in question is an end-to-end setup.py install test that makes a virtualenv, which I think is failing because it wants to slurp down pip and setuptools...)
> > >>
> > >
> > >
> > > You could just tell virtualenv not to pull down the latest pip/setuptools/etc? That seems like the best solution here since presumably you don’t want your tests hitting the network unless required anyways?
> >
> > That sounds like exactly what I want - do you know how to do that? Is
> > that the --never-download flag which says it does nothing on my Python
> > 2.7.13? (but maybe Danek has an older virtualenv?)
>
> We have virtualenv 15.0.1, on S12, and 12.0.7 on 11.3. Python is 2.7.13
> and 2.7.9, respectively.
>
> Oddly, --never-download says it's deprecated on 12.0.7, but not on 15.0.1
> (where it's also added the --no-download alias).
And, FWIW, adding --never-download to the invocation allows the test to
succeed for me.
Thanks,
Danek
More information about the Mercurial-devel
mailing list