[PATCH 3 of 3] patch: rewrite reversehunks (issue5337)

Sean Farley sean at farley.io
Wed Jun 21 13:30:23 EDT 2017


Martin von Zweigbergk via Mercurial-devel
<mercurial-devel at mercurial-scm.org> writes:

> On Tue, Jun 20, 2017 at 8:45 PM, Jun Wu <quark at fb.com> wrote:
>> # HG changeset patch
>> # User Jun Wu <quark at fb.com>
>> # Date 1498014757 25200
>> #      Tue Jun 20 20:12:37 2017 -0700
>> # Node ID 214414ec00522324510466ff63f265db6b2b0358
>> # Parent  4fddabb1c843b8068063c98cabbb55b3b9276d64
>> # Available At https://bitbucket.org/quark-zju/hg-draft
>> #              hg pull https://bitbucket.org/quark-zju/hg-draft -r 214414ec0052
>> patch: rewrite reversehunks (issue5337)
>
> Please explain a bit how this solves the problem. I'm sure it's
> obvious to you, but this series is a complete mystery to me. Sure, I
> could read the code and puzzle it all together, but since you already
> know what it's for, it would be more efficient for us if you
> explained.
>
> Also, it feels like these three patches belong in a single patch, but
> maybe it will be clearer what the purpose of each patch is once you've
> explained it.

For what it's worth, I think the patches are split just fine. It's our
usual add function X, add function Y, change function Z to use X+Y, no?
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 800 bytes
Desc: not available
URL: <http://www.mercurial-scm.org/pipermail/mercurial-devel/attachments/20170621/ec820b5b/attachment.sig>


More information about the Mercurial-devel mailing list