[PATCH 1 of 5] scmutil: make cleanupnodes handle filtered node

Jun Wu quark at fb.com
Wed Jun 28 11:10:40 EDT 2017


Excerpts from Martin von Zweigbergk's message of 2017-06-27 23:22:28 -0700:
> > +  >     with repo.wlock():
> > +  >         with repo.lock():
> > +  >             with repo.transaction('delayedstrip'):
> 
> We're on Python 2.7 now, so you can combine these three into a single
> with-block.

Good idea.

> > +  >                 # intentionally call cleanupnodes twice to let it handle
> 
> Twice? It looks like it's once.

Sorry. The comment should be removed.


More information about the Mercurial-devel mailing list