[PATCH] tests: more completely restore the environment in syshgenv

[Yuya Nishihara]

On Wed, 28 Jun 2017 12:34:56 -0700, Adam Simpkins wrote:
> # HG changeset patch
> # User Adam Simpkins <simpkins at fb.com>
> # Date 1498677802 25200
> #      Wed Jun 28 12:23:22 2017 -0700
> # Node ID 236c593941ab8034c500039c54bee0b3a19a0cef
> # Parent  649cb52c8cd94ab98068004e40bf9947de62a0ce
> tests: more completely restore the environment in syshgenv

Just FYI.

(before this patch)

% ./run-tests.py -l test-check-commit.t
--- /home/yuya/work/hghacks/mercurial-review/tests/test-check-commit.t
+++ /home/yuya/work/hghacks/mercurial-review/tests/test-check-commit.t.err
@@ -17,5 +17,9 @@            
   >        echo             
   >   fi                    
   > done                    
+  obsolete feature not enabled but 135142 markers found! 
+  obsolete feature not enabled but 135142 markers found! 
+  obsolete feature not enabled but 135142 markers found! 
+  obsolete feature not enabled but 135142 markers found! 

(after this patch)

% ./run-tests.py -l test-check-commit.t
--- /home/yuya/work/hghacks/mercurial-review/tests/test-check-commit.t
+++ /home/yuya/work/hghacks/mercurial-review/tests/test-check-commit.t.err
@@ -17,5 +17,25 @@
   >        echo
   >   fi
   > done
+  *** failed to import extension evolve: No module named evolve
+  *** failed to import extension textful: No module named textful
+  *** failed to import extension textful.encoding: No module named textful.encoding
+  obsolete feature not enabled but 135142 markers found!
+  *** failed to import extension evolve: No module named evolve
+  *** failed to import extension textful: No module named textful
+  *** failed to import extension textful.encoding: No module named textful.encoding
+  obsolete feature not enabled but 135142 markers found!
+  *** failed to import extension evolve: No module named evolve
+  *** failed to import extension textful: No module named textful
+  *** failed to import extension textful.encoding: No module named textful.encoding
+  obsolete feature not enabled but 135142 markers found!
+  *** failed to import extension evolve: No module named evolve
+  *** failed to import extension textful: No module named textful
+  *** failed to import extension textful.encoding: No module named textful.encoding
+  obsolete feature not enabled but 135142 markers found!
+  *** failed to import extension evolve: No module named evolve
+  *** failed to import extension textful: No module named textful
+  *** failed to import extension textful.encoding: No module named textful.encoding
+  obsolete feature not enabled but 135142 markers found!

I haven't investigated the problem yet.

Honestly I don't understand why using the system hg is more reliable. IMHO,
depending externals introduces more possible instabilities. And with more
heuristics, more painful debugging required.