[PATCH] tests: enable obsolete markers when invoking system hg to avoid warnings

[Adam Simpkins]

On Jun 29, Matt Harbison wrote:
> # HG changeset patch
> # User Matt Harbison <matt_harbison at yahoo.com>
> # Date 1498708353 14400
> #      Wed Jun 28 23:52:33 2017 -0400
> # Node ID fea411e4e1f3c098dc8928e08bc2ce57091ffb05
> # Parent  b9ea297237606ab49ea81aa80b44ede8f49ecc5b
> tests: enable obsolete markers when invoking system hg to avoid warnings
> 
> A couple of tests started spitting out 'obsolete feature not enabled...' after
> 6c113a7dec52.  I only noticed because I have evolve enabled globally- enabling
> it in the local repo also avoids the warning.
> 
> diff --git a/tests/helpers-testrepo.sh b/tests/helpers-testrepo.sh
> --- a/tests/helpers-testrepo.sh
> +++ b/tests/helpers-testrepo.sh
> @@ -11,7 +11,7 @@
>  syshg () {
>      (
>          syshgenv
> -        exec hg "$@"
> +        hg "$@" --config experimental.evolution=createmarkers
>      )
>  }

I think there's something else going wrong here that I don't
understand yet.  This doesn't seem like the right fix to me, and I'd
like to help track down what's actually going wrong.

The goal of syshg is to run "hg" with the exact same settings used
when you manually run "hg" by hand from your shell.  We shouldn't need
to pass in "--config experimental.evolution=createmarkers" unless you
always manually pass in that flag when interacting with your
repository.

It seems like for some reason syshgenv isn't completely restoring the
configuration as desired.

Can you try running "hg config --debug | grep createmarkers" from your
shell and report the output, to try and help identify where this
setting normally comes from for you?

-- 
Adam Simpkins
simpkins at fb.com