[PATCH] posix: update os.popen with subprocess (issue4746)

Rishabh Madan rishabhmadan96 at gmail.com
Thu Mar 2 18:01:07 EST 2017


# HG changeset patch
# User Rishabh Madan <rishabhmadan96 at gmail.com>
# Date 1488495530 -19800
#      Fri Mar 03 04:28:50 2017 +0530
# Node ID dde3cd0607652020b3b2e495e8a688383cf916ba
# Parent  71f692f1f678d86ffb4f95a3621aacfdaeb96b05
posix: update os.popen with subprocess (issue4746)

While importing a patch, we use a patch tool, say 'patch --merge', and the
patch doesn't merge cleanly, 'patch --merge' will return with exit status 1,
but 'hg import' displays 'abort: patch command failed: exited with status 256'.
This patch intends to replace the deprecated os.popen with subprocess.Popen
to return the correct output.

diff -r 71f692f1f678 -r dde3cd060765 mercurial/posix.py
--- a/mercurial/posix.py	Wed Mar 01 20:22:04 2017 +0100
+++ b/mercurial/posix.py	Fri Mar 03 04:28:50 2017 +0530
@@ -16,6 +16,7 @@
 import re
 import select
 import stat
+import subprocess
 import sys
 import tempfile
 import unicodedata
@@ -419,7 +420,7 @@
     return cmd
 
 def popen(command, mode='r'):
-    return os.popen(command, mode)
+    return subprocess.Popen(command, shell=True, stdout=subprocess.PIPE).stdout
 
 def testpid(pid):
     '''return False if pid dead, True if running or not sure'''


More information about the Mercurial-devel mailing list