[PATCH evolve-ext] setup.py: remove unused and harmful code importing mercurial
raf at durin42.com
Thu Mar 9 19:06:44 EST 2017
On Thu, Mar 09, 2017 at 10:22:44AM -0800, Pierre-Yves David wrote:
> On 03/09/2017 09:52 AM, Martin von Zweigbergk via Mercurial-devel wrote:
> > # HG changeset patch
> > # User Martin von Zweigbergk <martinvonz at google.com>
> > # Date 1489077180 28800
> > # Thu Mar 09 08:33:00 2017 -0800
> > # Node ID b7133ce4fc5afbcbb617eba6adea7cd7f10f8b2b
> > # Parent 74934195747b437ac49958cbb4deb2287753e1db
> > setup.py: remove unused and harmful code importing mercurial
> > This was failing on some build system we have. The import seemed to
> > succeed, but then mercurial.__all__ would fail. I don't know why, but
> > since it's unused anyway, let's just drop it.
> That part was from a setup.py from Augie. From IRC, you have seen with him
> already so I'm taking the patch.
I believe that's vestigial garbage that's been blindly carried around
for about a decade now. It's never done anything in that setup.py that
you inherited it from AFAICT.
> Pierre-Yves David
> Mercurial-devel mailing list
> Mercurial-devel at mercurial-scm.org
More information about the Mercurial-devel