[PATCH 3 of 9 py3 v3] context: work around `long` not existing on Python 3

Yuya Nishihara yuya at tcha.org
Sun Mar 12 14:37:13 EDT 2017


On Sun, 12 Mar 2017 11:15:59 -0700, Martin von Zweigbergk via Mercurial-devel wrote:
> On Sun, Mar 12, 2017 at 11:02 AM, Martin von Zweigbergk
> <martinvonz at google.com> wrote:
> > On Sun, Mar 12, 2017 at 10:59 AM, Augie Fackler <raf at durin42.com> wrote:
> >> # HG changeset patch
> >> # User Augie Fackler <augie at google.com>
> >> # Date 1489283824 18000
> >> #      Sat Mar 11 20:57:04 2017 -0500
> >> # Node ID c4a50c84504fe6eaae95915f401e9d6826e4d19f
> >> # Parent  d656211a72279aa55428121be114b4059e7117ab
> >> context: work around `long` not existing on Python 3
> >>
> >> I can't figure out what this branch is even trying to accomplish, and
> >> it was introduced in ac89a23ca814 which doesn't really shed any
> >> insight into why longs are treated differently from ints.
> >
> > I'm guessing it's because longs can't be revnums, so they are assumed
> > to come from a decimal-only prefix of a nodeid. Just a guess. And of
> > course there are no tests for it.
> 
> I was thinking that hgweb might create a context from something that
> looked like a long, but even visiting /rev/252232621165917755727729 in
> the hg core repo works fine. I'm done looking into this curiosity :-)

Perhaps it exists just for avoiding exception caused by passing long to
string functions.

https://www.mercurial-scm.org/pipermail/mercurial-devel/2012-May/040438.html


More information about the Mercurial-devel mailing list