[PATCH 4 of 5 V2] util: add a getfstype method

Jun Wu quark at fb.com
Sun Mar 12 15:06:32 EDT 2017


Excerpts from Yuya Nishihara's message of 2017-03-12 11:58:40 -0700:
> > That's good to know. I actually had 3 patches to move it to vfs, but was
> > concerned about the future "repostorage" layer holding vfs objects that
> > won't get invalidated across chg workers.
> 
> If the filesystem at the cached repository location changed, cache should be
> invalidated and repostorage would be recreated anyway.

Even if location does not change, the user can run "mount" to change the
"mtab" that affects us.

Querying "mtab" confidently is expensive. And "mtab" can answer all vfs
queries. So I think it's better to cache "mtab" per process, instead of
caching "fstype" per vfs.


More information about the Mercurial-devel mailing list