[PATCH 7 of 7 V3] util: enable hardlink for copyfile

Jun Wu quark at fb.com
Sun Mar 12 15:18:11 EDT 2017


Excerpts from Mads Kiilerich's message of 2017-03-12 11:48:35 -0700:
> I only see mentioning of problems with Windows on the client side. 
> Matt's theory of the source of the cache coherency issue suggested that 
> it was interaction between client and server side caches. Non-windows 
> client side implementations may or may not have the same problem, but I 
> see nothing suggesting they have.
> 
> That might of course be because most users of repos on CIFS are Windows 
> users. The problem is serious when it happens, but considering the 
> non-Windows uncertainty, the small amount of non-Windows users using 
> CIFS repos, and the negative impact on all non-Windows users, it might 
> be justified to be less conservative for non-Windows.

Per discussion with Augie yesterday, I prefer the very conservative
approach. That's why I added the "_isprocgenuine" check which looks
expensive but will greatly increase our confidence, and spent 2 hours
checking kernel code, doing experiments, and writing the commit message.

> 
> /Mads


More information about the Mercurial-devel mailing list